This page last changed on Oct 08, 2012 by fekete kamosh.

Hi,
I found that navigation to proper screen is not always functional. After clicking on a button with defined navigation navigate to another screen should be triggered but nothing happens sometimes.

I think there is a wrong comparison used in org.openremote.web.console.service.PanelServiceImpl (https://openremote.svn.sourceforge.net/svnroot/openremote/workspace/richturner/WebConsole_2_0_0_template/src/org/openremote/web/console/service/PanelServiceImpl.java)

public class PanelServiceImpl implements PanelService {
  ...
	@Override
	public Screen getScreenById(Integer screenId, Integer groupId) {
		Screen screen = null;
		boolean groupContainsScreen = false;
		
		if (groupId == null) {
			groupContainsScreen = true;
		} else {
			for (Integer sId : getGroupScreenIds(groupId)) {
                                //if (sId == screenId) { // current comparison
				if (sId.equals(screenId)) {
					groupContainsScreen = true;
					break;
				}
			}
		}
  
  ...
}

Could you please look at this?

Thank you

Fekete

Hi Fekete,

I'll have a look at this.

Rich

Posted by kurrazyman at Oct 09, 2012 18:30

Bug raised: WEBCONSOLE-49

Bug fixed and committed to the repo you mentioned above, if you want to compile with the fix or if you want a compiled version let me know.

I should be more careful and not rely on autoboxing!

Thanks,

Rich

Posted by kurrazyman at Oct 09, 2012 18:46
Document generated by Confluence on Jun 05, 2016 09:32